Skip to content

feat(clone_on_ref_ptr): don't add a & to the receiver if it's a reference #15742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat(clone_on_ref_ptr): don't add a & to the receiver if it's a reference #15742

wants to merge 4 commits into from

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Sep 23, 2025

Fixes #15741

Depends on #15740, so @rustbot label S-blocked

changelog: [clone_on_ref_ptr]: don't add a & to the receiver if it's a reference

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Sep 23, 2025
@github-actions GitHub Actions
Copy link

Lintcheck changes for d0e7940

Lint Added Removed Changed
clippy::clone_on_ref_ptr 0 0 17

This comment will be updated if you push new changes

@samueltardieu samueltardieu removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samueltardieu samueltardieu

Labels
S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clone_on_ref_ptr adds an unnecessary &
3 participants
@ada4a @rustbot @samueltardieu